feat: add a plugable logging system.#153
Open
yingcai-cy wants to merge 6 commits into
Open
Conversation
lidavidm
reviewed
Jul 25, 2025
Comment on lines
+218
to
+224
| default_logger_ = std::static_pointer_cast<void>(logger); | ||
| log_func_ = [logger](LogLevel level, std::string_view format_str, | ||
| const std::string& formatted_message) { | ||
| if (logger->ShouldLog(level)) { | ||
| logger->LogImpl(level, "{}", formatted_message); | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
Ultimately we still do a dynamic call, does it save us anything versus a virtual call? It is significantly more complicated
Contributor
Author
There was a problem hiding this comment.
Yes, function pointers are generally faster than virtual calls, and in some scenarios, the compiler is able to inline them, which can further improve performance.
wgtmac
reviewed
Jul 29, 2025
Contributor
Member
|
@evindj Thanks for your interest! I believe @kamcheungting-db is currently working on this so it is better to avoid conflict. We can postpone loggingmetricsreporter once logging has been added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.